orhun / systeroid

A more powerful alternative to sysctl(8) with a terminal user interface 🐧
https://systeroid.cli.rs
Apache License 2.0
1.28k stars 23 forks source link

refactor(sysctl): Refactor some controller code #146

Closed matthiasbeyer closed 1 year ago

matthiasbeyer commented 1 year ago

Description

Some more code refactoring

Motivation and Context

Not required at all, just found that nice.

How Has This Been Tested?

It hasn't :laughing:

Screenshots / Logs (if applicable)

Types of Changes

Checklist:

matthiasbeyer commented 1 year ago

A quick bisect told me that the first patch of this series broke this... which I do not understand... do you have some insight?

orhun commented 1 year ago

Yup, I just checked cargo run -- -A and it lists only the deprecated parameters.

matthiasbeyer commented 1 year ago

Should be fixed now, please have another look! :tada:

codecov-commenter commented 1 year ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
systeroid-core/src/sysctl/controller.rs 76.48% <81.25%> (-0.98%) :arrow_down:

... and 1 file with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!.