ori-community / wotw-rando-client

Game Client/Mod for the Ori and the Will of the Wisps Randomizer
https://wotw.orirando.com
Other
20 stars 15 forks source link

Combat Shrine icons on the in logic filter #320

Open SiriusAshling opened 1 year ago

SiriusAshling commented 1 year ago

Icons for Combat Shrines are currently inconsistent with other icons in the in logic filter.

For other icons, the in logic filter removes all icons that are not pickup locations and then displays the pickup locations either transparent or opaque depending on whether they are in logic (on default settings)

For Combat Shrines, it displays two icons on top of eachother, the combat shrine icon itself (as it appears in the normal map) and a shard slot icon on top that isn't usually ever displayed. The Combat shrine icon always stays transparent, regardless of whether the pickup is in logic, the shard slot icon is either transparent or opaque if you can logically reach it. This is confusing because there is not a single other icon present on the in logic filter that stays transparent even if the corresponding pickup is in logic. It also makes it hard to see the shard slot icon when it is opaque, since it overlaps with the transparent icon. New players often overlook the Combat Shrine icons because of this.

Proposed solution: Don't show the shard slot icon, only show the combat shrine icon and make it transparent or opaque like all other icons This would be consistent with all other icons; the Combat Shrine is the associated icon with the pickup location, the shard slot icon doesn't usually exist there. In particular, this would be consistent with how Spirit Trials work. Additionally, the Combat Shrine icon is bigger than the very tiny shard slot icon, so it might be better suited to solve the visibility problem.