ori-drs / spot_ros

Other
2 stars 0 forks source link

Enable camera frames in URDF #2

Closed mmattamala closed 3 years ago

mmattamala commented 3 years ago

This PR adds the camera frames as fixed frames in the xacro files. Since Spot actually publishes the TFs for the cameras (but at frame rate, as part of the camera publication), we obtained the fixed transformations from a rosbag and confirmed they didn't change over time.

The changes include:

I tested the flag using view_model.launch, and also lauching the driver in my laptop and checking that the static transforms were being published when the flag was enabled (even when Spot was not connected).

@heuristicus Please test it as we discussed today. Tell me if you need me to modify anything or feel free to do it if it's easier.

Flag disabled: rviz_spot_flag_disabled

Flag enabled: rviz_spot_flag_enabled

heuristicus commented 3 years ago

I fixed the if statements and also modified the getImageMsg function to make it so that the whole tf computation step is skipped if None is provided as the frame. It probably doesn't make much difference in terms of computation but better to not do things that aren't necessary.

Dynamic frames: spot_tf_dynamic_frames

Static frames: spot_tf_static_frames

But with these changes for some reason I can't see the depth clouds any more, will test more and make another commit to fix.

mmattamala commented 3 years ago

Nice, it was a minor change fortunately.