search

ori-edge / k8s_gateway

A CoreDNS plugin to resolve all types of external Kubernetes resources
Apache License 2.0
295 stars 64 forks source link

Make zonefile roll #112

Closed xorcat closed 2 years ago

xorcat commented 2 years ago

I discovered that modifying the custom zonefile (defined by .Values.zoneFile) did not cause my deployment to roll a new version.

After seeing this helm documentation I came up with this solution to include an annotation with the value as a hash of the Values contents.

I'm pretty new to helm and kube, so please let me know if I've stuffed anything up here - happy to get some feedback.

networkop commented 2 years ago

thanks @xorcat, this is neat, I haven' t seen this before. But it looks like it's going to work. have you tested this locally?

xorcat commented 2 years ago

I sure have @networkop, I'm running my branch in my cluster atm and its been rolling the deployment whenever I make config changes.

networkop commented 2 years ago

sweet as. thanks the contribution @xorcat !