Added static clusterIP to Helm chart

ori-edge / k8s_gateway

A CoreDNS plugin to resolve all types of external Kubernetes resources

Apache License 2.0

295 stars 64 forks source link

Closed Crewat closed 2 years ago

Crewat commented 2 years ago

Added static clusterIP to Helm chart (fixes #131) Fixed typo in README

networkop commented 2 years ago

hey @Crewat , you're still missing the clusterIP in the template https://github.com/ori-edge/k8s_gateway/blob/master/charts/k8s-gateway/templates/service.yaml Once you've added it, can you test it locally, to make sure it renders the manifest as expected and bump the version of a helm chart as described here https://github.com/ori-edge/k8s_gateway#helm-charts

Crewat commented 2 years ago

Hey @networkop, I'm not sure what you mean with missing the clusterIP in the service template as I did add it at https://github.com/Crewat/k8s_gateway/blob/helm-static-clusterip/charts/k8s-gateway/templates/service.yaml#L21

I tested the chart locally and everything seems to work as expected.

I will bumb the version of the Helm chart after your confirmation that everything is in order.

networkop commented 2 years ago

yeah, my bad, I must've missed it. so yeah, just bump the version chart and run make helm-update