ori-edge / k8s_gateway

A CoreDNS plugin to resolve all types of external Kubernetes resources
Apache License 2.0
295 stars 64 forks source link

[Helm Chart] plugin/loop: no next plugin found #136

Closed Diaoul closed 2 years ago

Diaoul commented 2 years ago

Running the helm chart with most values default, here is what the log is on startup.

[INFO] 127.0.0.1:33633 - 41080 "HINFO IN 8237687624183295910.7537598229432224564. udp 57 false 512" - - 0 0.00005595s
[ERROR] plugin/errors: 2 8237687624183295910.7537598229432224564. HINFO: plugin/loop: no next plugin found

It seems there is an issue with the loop plugin configuration when no forwarder is set?

networkop commented 2 years ago

Hi @Diaoul , can you include your helm chart values you used and the command to install it?

Diaoul commented 2 years ago

Installed using fluxcd: https://github.com/Diaoul/home-ops/commit/28fa1ee2b90236c7dc8a4d01f62d822a324bdadc#diff-a86e1e8b391bf413635e508861f9f23770e923047852350990e882acf9aaea85R18

    image:
      repository: oriedge/k8s_gateway
      tag: v0.3.1
    domain: ${DOMAIN}
    service:
      type: LoadBalancer
      externalIPs:
        - ${K8S_GATEWAY_IP}
      externalTrafficPolicy: Local
networkop commented 2 years ago

I don't think it's a k8s_gateway issue. I see the same behaviour with upstream coredns build. Looking at the loop plugin readme, I think the error you're seeing is by design. It's supposed to detect forwarding loops, and forward is the only plugin that can create this loop. so if it's not defined, then you don't really need a loop plugin either.

networkop commented 2 years ago

I guess we could refactor the k8s_gateway helm chart to make loop plugin optional.

Diaoul commented 2 years ago

I guess we could refactor the k8s_gateway helm chart to make loop plugin optional.

Sorry my issue was not very clear :bow: Yes this is what I had in mind: in case there is no forward, no need to add the loop plugin.

Diaoul commented 2 years ago

Really cool and much closer to the coredns chart! Thank you! ❤️