Allow passing domains with zoneFile

ori-edge / k8s_gateway

A CoreDNS plugin to resolve all types of external Kubernetes resources

Apache License 2.0

295 stars 63 forks source link

Allow passing domains with zoneFile #158

Closed qlonik closed 1 year ago

qlonik commented 1 year ago

This PR addresses #155 by allowing for optional domains field in zoneFile object. It also allows passing more than one zoneFile using zoneFiles array in a way similar to coredns: https://github.com/coredns/helm/blob/4a9f0dd13f08ff41ce768b11a830e48e54ef8b1d/charts/coredns/templates/configmap.yaml#L40-L42

networkop commented 1 year ago

Looks good. Let's not worry about backward compatibility and drop the singular zoneFile value completely, otherwise it's just confusing. You can bump the helm chart's major version to signal breaking changes, but I think most other people ignore semver conventions for helm charts. Can you also bump the helm chart version as described here https://github.com/ori-edge/k8s_gateway#helm-charts

qlonik commented 1 year ago

updated it

networkop commented 1 year ago

lgtm. thanks!