search

ori-edge / k8s_gateway

A CoreDNS plugin to resolve all types of external Kubernetes resources
Apache License 2.0
316 stars 65 forks source link

charts: service: move loadBalancerIP from port to top level of spec #22

Closed BinaryMan32 closed 3 years ago

BinaryMan32 commented 3 years ago

The loadBalancerIP setting should be at the same level as type: LoadBalancer, not in the per-port settings.

morganchristiansson commented 3 years ago

This is correct. Apologies - I added it with wrong indentation in #17. LGTM.

Also need to bump chart version.

BinaryMan32 commented 3 years ago

@morganchristiansson I added another commit to bump the chart version to 1.0.2. Anything else I'd need to do before this PR can be merged?

morganchristiansson commented 3 years ago

Looks good to me. @networkop can you merge. (btw docker build failure is from unrelated issue #18 )

Marx2 commented 3 years ago

who can push it?

morganchristiansson commented 3 years ago

I had a look. I made chart 1.0.2 available from helm repo url https://morganchristiansson.github.io/k8s_gateway

After running make helm-package to update index.yaml and enabled GitHub pages from master on my fork https://github.com/morganchristiansson/k8s_gateway.

(Someone will merge this soon don't expect me to host it except for this fix)

networkop commented 3 years ago

thanks @morganchristiansson and @BinaryMan32 . I am no longer part of the ori-edge org, but I've asked to be added to the list of maintainers (see #23 ). I'll try to ping people offline to see if it's possible. If not, I suspect we may have to fork this and move the active maintenance elsewhere.

morganchristiansson commented 3 years ago

Forking would be easy if ori edge can add note in readme. Can even rename/move repo and github will redirect to repo in new org/user.

networkop commented 3 years ago

all good @morganchristiansson , I've been added to the list of maintainers.