search

ori-edge / k8s_gateway

A CoreDNS plugin to resolve all types of external Kubernetes resources
Apache License 2.0
289 stars 61 forks source link

Helm chart: allow custom service labels #256

Closed dnrce closed 5 months ago

dnrce commented 6 months ago

In addition to annotations, for my use case involving matchLabels it would be helpful to be able to add additional labels to the Service. This PR adds a service.labels value to the Helm chart to allow custom labels. The implementation copies that of service.annotations.

dnrce commented 5 months ago

(Ideally also merge #258 before updating the Helm index with the new release. 🙂)

dnrce commented 5 months ago

Thanks @networkop! When can I hope for a new chart release? I wasn't sure about the security of doing a PR with a new tgz, but I'm happy to open one if you'd take it.

networkop commented 5 months ago

I'll cut a new release tomorrow

networkop commented 5 months ago

@dnrce I've bumped the helm chart version

dnrce commented 5 months ago

@networkop thank you!