oridb / mc

Myrddin Compiler
MIT License
387 stars 34 forks source link

Completion of error handling #177

Closed elfring closed 6 years ago

elfring commented 6 years ago

Would you like to add more error handling for return values from functions like the following?

oridb commented 6 years ago

Checking errors on printf is pretty useless. Otherwise, I'll gladly take a patch for this

elfring commented 6 years ago

I suggest to avoid ignorance of return values a bit more. Would you like to detect every error situation as early as possible?

refi64 commented 6 years ago

What are you going to do if printf fails though? It's not like you can log a message. There's no point in checking IMO.

elfring commented 6 years ago
oridb commented 6 years ago

As stated, pull requests welcome.

elfring commented 6 years ago
oridb commented 6 years ago

1) I already use static source code analysis where appropriate. It's often noisy and produces useless output, so it's quite time consuming. How do you think about to improve static source code analysis tools so that false positives rates are negligible? 2) No. 3) You have clearly not read and understood the code. Please don't propose changes without specifics.

elfring commented 6 years ago

We got different expectations around software development methodologies.