search

orientechnologies / orientdb-docker

OrientDB running in a docker container
MIT License
63 stars 63 forks source link

Implement Docker health check #28

Closed robfrank closed 6 years ago

robfrank commented 7 years ago

Reference docs:

https://docs.docker.com/engine/reference/builder/#healthcheck

stuartpb commented 6 years ago

It looks like this was added and then... removed? Any insights as to why?

I'm currently looking at a patch to add HEALTHCHECK to the RethinkDB Dockerfiles, and I'm trying to understand how other official images have done it.

robfrank commented 6 years ago

You're right, was added and then removed. The docker team asked me to remove during the pr:

https://github.com/docker-library/official-images/pull/2831

Pointing to this comment:

https://github.com/docker-library/cassandra/pull/76#issuecomment-246054271

So, even it seems a good idea, the docker team doesn't think it is: I don't think you will find an official image with health-check defined.