search

orientechnologies / orientdb-gremlin

TinkerPop3 Graph Structure Implementation for OrientDB
Apache License 2.0
91 stars 32 forks source link

Fix index not being used when hasLabel step has multiple labels #125

Closed ddrozdov closed 7 years ago

ddrozdov commented 7 years ago

This fixes #124.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.04%) to 84.586% when pulling 49865e9bf4215ca658faf42d70d16f6826248289 on ddrozdov:issue124 into d0e14e1cf912372ac098692c16c1a318362488b2 on orientechnologies:master.

wolf4ood commented 7 years ago

hi @ddrozdov

thanks for this PR, i will review it shortly. Do you have also a test case that fails with multiple labels?

Enrico

ddrozdov commented 7 years ago

Hi @maggiolo00

No, I don't have a test case for this and, in fact, the test wouldn't fail, there would just be a huge performance penalty since a lot of extra data would be loaded to the client.

wolf4ood commented 7 years ago

@ddrozdov ok if you have a snippet that reproduce the issue just paste it here I will eventually try to turn it in a test case

Thanks

wolf4ood commented 7 years ago

Thanks @ddrozdov