search

orientechnologies / orientdb-gremlin

TinkerPop3 Graph Structure Implementation for OrientDB
Apache License 2.0
93 stars 32 forks source link

Gtests #26

Closed velo closed 8 years ago

velo commented 9 years ago

last numbers: Tests run: 818, Failures: 2, Errors: 12, Skipped: 369

now we have pretty much ALL tests on OrientGraphStructureStandardIT fixed!

the two failures are true bugs on this driver

velo commented 8 years ago

Tests are almost 100% Tests run: 816, Failures: 21, Errors: 19, Skipped: 369

Just take a look and if you agree with my changes, go head

velo commented 8 years ago

Latest numbers: Tests run: 818, Failures: 17, Errors: 19, Skipped: 369 2 failures are true failures one transaction related and the other related to edge removal!

velo commented 8 years ago

last numbers: Tests run: 818, Failures: 2, Errors: 12, Skipped: 369

now we have pretty much ALL tests on OrientGraphStructureStandardIT fixed!

the two failures are true bugs on this driver

mpollmeier commented 8 years ago

awesome, great work! do you wanna fix the two bugs you are referring to and then we'll merge this?

velo commented 8 years ago

@mpollmeier I tried, but I failed miserably =/

one is transaction related... if you say you support transaction feature, it will turn it on (randomly), but that break tests since we try to change the schema... and that can only be done transactionless

The other, is the edge remove(), goes into an infinite loop

mpollmeier commented 8 years ago

hmm, I can have a look, but will have to wait until tomorrow. Just saw that you're based in Wellington - I'm in Auckland :) Your github profile still says Brazil...

velo commented 8 years ago

Fixed!

mpollmeier commented 8 years ago

did you amend the last commit then? sounds great! however, I can't seem to run the tests locally, they always freeze. I run mvn install to execute them...

velo commented 8 years ago

no, I mean my github profile =D

velo commented 8 years ago

ok, fixed the issue we discussed!

feel free to merge if you agree with my changes.

mpollmeier commented 8 years ago

i still can't run them locally on my machine - what's your trick?

velo commented 8 years ago

Serious? Why not? Any error or what?

mpollmeier commented 8 years ago

it just randomly hangs at one test most of the time. I just tried it again though and the tests completed fine. output: Tests run: 818, Failures: 2, Errors: 12, Skipped: 373

So there's still a few issues?

velo commented 8 years ago

The errors are groovy tests related.... what I got 100% are the structure tests. Anyway, the broken groovy tests need to be fixed on tinkerpop itself