option to disable classname prefixing

orientechnologies / orientdb-gremlin

TinkerPop3 Graph Structure Implementation for OrientDB

Apache License 2.0

93 stars 32 forks source link

option to disable classname prefixing #43

Closed gbicou closed 8 years ago

gbicou commented 8 years ago

This is an implementation of an option to remove the default behaviour of class prefixing.

OrientGraphFactory.setLabelAsClassName() to disable the default prefixing of classnames with V or E
OrientGraph.labelToClassName() and OrientGraph.classNameToLabel() helpers
OrientGraph.getEdgeIndexedKeys() and OrientGraph.getVertexIndexedKeys() verify the super class
OrientGraph.createClass() throws if creating the same class with a different base class
test suites modified

velo commented 8 years ago

LGTM

mpollmeier commented 8 years ago

Can you explain the benefit of this please? The reason for prefixing the class names with V and E is so that you can use the same labels for vertices and edges. Why would anyone not like to do that?

gbicou commented 8 years ago

The main reason is that I'm unable to use this driver with an existing databaase schema.

I already have a Person class in orientdb but hasLabel("Person") miss them.

Maybe i'm doing it wrong.

mpollmeier commented 8 years ago

ok yeah that makes sense. happy to merge after you've resolved the conflicts

velo commented 8 years ago

FWIW, I changed all master code format... https://github.com/mpollmeier/orientdb-gremlin/blob/master/driver/src/config/eclipse/formatter/java.xml

Probably if you rebase should have little number of conflicts!

velo commented 8 years ago

I made the merge for you... you just need to apply to your branch and all shall start to look green https://github.com/bicouy0/orientdb-gremlin/pull/1