search

orientechnologies / orientdb-gremlin

TinkerPop3 Graph Structure Implementation for OrientDB
Apache License 2.0
91 stars 32 forks source link

Support for UNIQUE and NOTUNIQUE indices on edges. #78

Closed johnrevill closed 8 years ago

johnrevill commented 8 years ago

Hi there,

I just had a go at getting index support for edges. It largely follows the approach taken for vertex indices.

There's also a small fix in OrientGraph.java for a potential ClassCastException being thrown during index lookup when using a remote connection. This has the exact same exception message as in the old issue #71 and seems to happen when using a remote connection and a NOTUNIQUE index.

Cheers, John

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.1%) to 84.257% when pulling 91ab9a32b1103521c8883df9dab72fce31d7c3c7 on johnrevill:master into 73cbc5ad16015b77d2daa094a79410bbc891a76f on mpollmeier:master.

velo commented 8 years ago

LGTM

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.3%) to 84.455% when pulling cf70835152aaf995386422053517a9b7b1e6f555 on johnrevill:master into 73cbc5ad16015b77d2daa094a79410bbc891a76f on mpollmeier:master.

mpollmeier commented 8 years ago

awesome, thank you! I'll release a new version shortly