orientechnologies / orientdb-gremlin

TinkerPop3 Graph Structure Implementation for OrientDB
Apache License 2.0
91 stars 32 forks source link

Use index for multiple provided values #80

Closed mpollmeier closed 8 years ago

mpollmeier commented 8 years ago

Adding index support when using within (multiple values) @velo can you review this please?

Travis fails with this error, I'm certain you know what's going on there... can you document in the readme how to format the code properly?

[ERROR] Failed to execute goal com.marvinformatics.formatter:formatter-maven-plugin:1.6.0.RC4:validate (validate) on project orientdb-gremlin: File '/home/travis/build/mpollmeier/orientdb-gremlin/driver/src/main/java/org/apache/tinkerpop/gremlin/orientdb/traversal/step/sideEffect/OrientGraphStep.java' format doesn't match! -> [Help 1]
velo commented 8 years ago

run mvn clean install on your machine and it will fix the format... them commit/push

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 84.236% when pulling ecc58630be5f79078049bdc10841403e775f1cab on use-index-for-multiple-provided-values into 353aaf83c17f6e57f15a0c258e0d3cf644275320 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 84.236% when pulling 049be6a181cd8a4c46d492199a92b4db6aa66e1f on use-index-for-multiple-provided-values into 353aaf83c17f6e57f15a0c258e0d3cf644275320 on master.

mpollmeier commented 8 years ago

thanks, any other thoughts on this?

velo commented 8 years ago

not really

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.2%) to 84.221% when pulling d91c3bb1dd451cabcc235db877ac0b4873d6b141 on use-index-for-multiple-provided-values into 353aaf83c17f6e57f15a0c258e0d3cf644275320 on master.

ddrozdov commented 7 years ago

@mpollmeier is there any reason why only Compare.eq and Contains.within are supported in OrientGraphStep.findIndex()? Other Compare.* predicates should work as well?

mpollmeier commented 7 years ago

No reason other than that the others aren't implemented yet :) Shouldn't be hard for most of them.