search

orientechnologies / orientjs

The official fast, lightweight node.js client for OrientDB
http://orientdb.com
Other
326 stars 67 forks source link

V8 Deprecation Warnings For deserializer.vcxproj #372

Open npetruzzelli opened 5 years ago

npetruzzelli commented 5 years ago

When executing npm install --save orientjs, I receive the following messages:

d:\code\node_modules\orientjs-native\lib\native\deserializer.cc(18): warning C4996: 'v8::Value::ToBoolean': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(10034): note: see declaration of 'v8::Value::ToBoolean'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(19): warning C4996: 'v8::String::Utf8Value::Utf8Value': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(2891): note: see declaration of 'v8::String::Utf8Value::Utf8Value'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(23): warning C4996: 'v8::Value::ToObject': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(10046): note: see declaration of 'v8::Value::ToObject'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(26): warning C4996: 'v8::String::Utf8Value::Utf8Value': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(2891): note: see declaration of 'v8::String::Utf8Value::Utf8Value'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(39): warning C4996: 'v8::String::Utf8Value::Utf8Value': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(2891): note: see declaration of 'v8::String::Utf8Value::Utf8Value'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(54): warning C4996: 'v8::String::Utf8Value::Utf8Value': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(2891): note: see declaration of 'v8::String::Utf8Value::Utf8Value'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(66): warning C4996: 'v8::Value::NumberValue': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(2475): note: see declaration of 'v8::Value::NumberValue'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(71): warning C4996: 'v8::Value::ToBoolean': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(10034): note: see declaration of 'v8::Value::ToBoolean'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(85): warning C4996: 'v8::Value::ToObject': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(10046): note: see declaration of 'v8::Value::ToObject'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(87): warning C4996: 'v8::String::Utf8Value::Utf8Value': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(2891): note: see declaration of 'v8::String::Utf8Value::Utf8Value'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(88): warning C4996: 'v8::Value::Equals': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(2481): note: see declaration of 'v8::Value::Equals'
d:\code\node_modules\orientjs-native\lib\native\writer.cc(108): warning C4996: 'v8::String::Utf8Value::Utf8Value': was declared deprecated [D:\Code\node_modules\orientjs-native\build\deserializer.vcxproj]
  c:\users\dev\.node-gyp\10.15.3\include\node\v8.h(2891): note: see declaration of 'v8::String::Utf8Value::Utf8Value'
wolf4ood commented 5 years ago

Hi @npetruzzelli

is this blocking the install? orientjs native should be optional and if you are using OrientJS 3.0.x with the new protocol it's not needed anymore, so you can ignore those warnings

Thanks

npetruzzelli commented 5 years ago

@wolf4ood - I don't think it affected the install. It is something I've only noticed in various packages since upgrading from Node 8.x to 10.x. My understanding is that it isn't broken now, but it may break in the near future (somewhere between Node 11 and 14 maybe?), so I wanted to file a bug since I didn't see one already.

I ended up having to switch to a different package since the project isn't using OrientDB anymore, but I like this project, so I wanted to at least give a heads up to whomever it may concern.