search

orientechnologies / orientjs

The official fast, lightweight node.js client for OrientDB
http://orientdb.com
Other
327 stars 67 forks source link

[Typescript]: Changes for typescript definition + add new typescript definition and embed it to orientjs package . #438

Open saeedtabrizi opened 3 years ago

saeedtabrizi commented 3 years ago

based on https://github.com/orientechnologies/orientjs/issues/184#issuecomment-694426843 i just a fix for it. Thanks @diegonc @wolf4ood, @lvca

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.1%) to 80.574% when pulling 283b6e0f1625b24e98cb144fdb4d61bac0f59cd6 on saeedtabrizi:develop into cdd45728b28f64dba0c39d6850be6a5ad1516d44 on orientechnologies:develop.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.01%) to 80.68% when pulling b6e3405ec06fd4a56ae5feebebdad11e6ed23933 on saeedtabrizi:develop into cdd45728b28f64dba0c39d6850be6a5ad1516d44 on orientechnologies:develop.

diegonc commented 3 years ago

Hi @saeedtabrizi. Where should I direct further feature requests for typings?

I'm referring particularly to the possibility of using a function in the let call documented at this test.

type OFnStatement = (s: OStatement) => OStatement;

interface OStatement extends OQuery<any> {
  ...
  let(name: string, value: string | OStatement | OFnStatement): OStatement;
}

class ODB extends events.EventEmitter {
  ...
  let(name: string, value: string | OStatement | OFnStatement): OStatement;
}
saeedtabrizi commented 3 years ago

@diegonc unfortunately the https://github.com/saeedtabrizi/DefinitelyTyped/orientjs deployment process is very slow , so I decided to continue here (in master project) . Welcome to all orientjs typings task in here . About the requested feature please write an issue with starting by [Typescript] in title . I will check and implement it asap . Many thanks .

saeedtabrizi commented 3 years ago

@diegonc , good news that we have the new feature that you requested only last hour . please write each feature or epic in a seprated issue by starting [Typescript] title . Thanks