search

orientechnologies / pyorient

OrientDB driver for Python that uses the binary protocol.
Apache License 2.0
119 stars 38 forks source link

updated SUPPORTED_PROTOCOL constant to 37 #29

Open rrmerugu opened 6 years ago

rrmerugu commented 6 years ago

this shall possibly support orientdb 3.0.0

rrmerugu commented 6 years ago

may be this shall call for version increment also !! in constants.py !

rrmerugu commented 6 years ago

@Ostico are there any modifications needed for this codebase to support orientdb 3.0.0 !!

OrientDBColin commented 6 years ago

Hi @rrmerugu,

Unfortunately, this solution won't work with OrientDB 3.0.3 and later.

It now adds a check to protocol 37 during the connect phase to see if a handshake were used.

It fails otherwise.

The simplest solution is to still use protocol 36 (OrientDB will adjust accordingly) until the handshake, etc. can be implemented and to comment out this in orient.py:

        if self.protocol > SUPPORTED_PROTOCOL:
            raise PyOrientWrongProtocolVersionException(
                "Protocol version " + str(self.protocol) +
                " is not supported yet by this client.", [])