Closed brucetony closed 3 years ago
Hi @brucetony
Thank you very much! I see you are still working on this PR, so please let me know when it's done, so that I can check and merge it.
As you can see, PyOrient did not have much maintenance lately and is lagging behind compared to OrientDB Core, all the contributions are much appreciated.
Thanks!
Luigi
Once I get the unit tests to all work, I will let you know. Luckily, this package was very well written so the changes required to keep this up to date are minimal, but the tests must be adapted to handle these changes. Happy to help!
I have spent some time trying to get the unit tests to work, but there is an issue with the OGM and transaction tests. Most everything else now works, but I should stress that my changes are specifically for OrientDB 3.1 and 3.2, I have not tested whether it is backward compatible. The primary patches are applied are:
decode_header()
method. I did this because according to the updated binary protocol for responses, token based sessions have an additional string term that needs to be decoded before the actual message can be decodedPlease let me know if you have any questions or concerns, always happy to help out.
Cheers, Bruce
Hi @brucetony
Thank you very much! I think it all makes sense; the failing tests are a concern, but having some progress in the compatibility with v 3.1 and 3.2 is very important for now, so I'm merging it.
Thanks!
Luigi
Aside from various syntax updates and Exception class additions, I rearranged some code in the
_decode_header()
method so that errors are properly parsed. Now when mistakes and errors are encountered, it does not throw the generic BaseException warning.