search

origgami / CMB2-grid

A grid system for Wordpress CMB2 library that allows columns creation
88 stars 21 forks source link

Only load CMB2Grid if CMB2 is active. #11

Closed jrfnl closed 8 years ago

jrfnl commented 8 years ago

This makes for leaner loading if CMB2 is not active as well as preventing some error messages if CMB2 is not active: undefined constant and such.

pablo-sg-pacheco commented 8 years ago

Thank you. Sorry for the delay

jrfnl commented 8 years ago

You're welcome and not to worry, 3 days is plenty fast ;-)

P.S.: just noticed that something weird has happened with the indentation of a line at the end of the file due to this PR. Would you like me to send in PR to fix that or leave it for when other changes are made ?

pablo-sg-pacheco commented 8 years ago

You are now declared my first contributor! Is that ok for you?

jrfnl commented 8 years ago

I feel honoured ;-)

FYI: generally - except for trivial changes like the spacing thingie - I will still work with PRs to facilitate code reviews, though I will push the PR-branch to the main repo in that case so others (in this case: you), can write directly to the branch if necessary. Ok ?

pablo-sg-pacheco commented 8 years ago

Good idea :) Thank you. If you have any thoughts let me know

jrfnl commented 8 years ago

Will do - will be sending in a couple of PRs in a minute and I'll open a few issues with ideas I could implement.