search

origgami / CMB2-grid

A grid system for Wordpress CMB2 library that allows columns creation
88 stars 21 forks source link

Inherit composer.json from CMB2 + packagist #34

Open slaFFik opened 7 years ago

slaFFik commented 7 years ago

https://github.com/WebDevStudios/CMB2/blob/trunk/composer.json

This way I will be able to install as a dependency in my own plugin via composer. Currently your composer.json creates separate wp-content directory inside my plugin.

Also, please add your library to packagist.

pablo-sg-pacheco commented 7 years ago

I already have a composer.json with type=wordpress-plugin

Do i have to add something else?

I've just added cmb2-grid to packagist. Could you try it please? Thanks

slaFFik commented 7 years ago

Assuming I have a composer.json file in own plugin dir.

Currently it's not possible to install your lib in own plugin using composer - instead of wp-content/plugins/own-plugin/vendor/origgami/CMB2-grid it will create wp-content/plugins/own-plugin/wp-content/plugins/CMB2-grid. At least it was so some time ago, when I checked.

pablo-sg-pacheco commented 7 years ago

I thought that using composer, cmb2-grid would be installed on plugins-folder/cmb2-grid. Wouldn't it be enough?

I think that using a custom install like you want, you'd have to setup a custom folder for cmb2-grid using a package or something