Closed xtermi2 closed 1 year ago
@xtermi2 can you run
./gradlew spotlessApply
This will format the code according to specifications.
@xtermi2 can you run
./gradlew spotlessApply
This will format the code according to specifications.
Done. Sorry, haven't read carefully your contribution guide :see_no_evil:
Currently
ObjectMapper#findAndRegisterModules
is not skipable by a subclass ofJacksonSnapshotSerializer
. This means all Modules in the classpath which supports registering via service loader will be registered. This is not always what is needed, like in our case:We use in our porject production code Afterburner (if JRE is <= 8) and Blackbird (if JRE is > 8). We have a switch when our ObjectMapper is configured, like this:
With this change a subclass of
JacksonSnapshotSerializer
can decide in itsconfigure
override ifObjectMapper#findAndRegisterModules
should be executed (just callsuper
) or if (like in our case) the impl should register needed modules manually (don't callsuper
).