originalnicodr / RELit

Mod to spawn lights in RE Engine games
https://framedsc.com/GeneralGuides/relit.htm
25 stars 4 forks source link

Fix the scene lights to have the same prioperties when turning them off and on again. #6

Closed originalnicodr closed 2 years ago

originalnicodr commented 2 years ago

For some reason, once you switch off all the scene lights and turn them back on again they don't return as they originally were, but with increased intensity? This might be because we are not really using a method to disable the lights but modifying the memory of each light, so it might be some sort of unexpected behavior going on in there.

We should keep our eyes open to alternative ways of doing this to see if we can avoid this problem.

Original scene lights: image

Scene lights after turning them off and on again: image

FransBouma commented 2 years ago

It might be due to the fact I just set the draw flag, but not the other 4 flags next to it like the model viewers do (they write 0x01010101 at 0x12 and then set flag 0x13 to true/false. However I haven't seen this in RE2 but it might also be related to the scene I was in and I didn't pay close attention to the lack of any shadows

FransBouma commented 2 years ago

This has been fixed in 1.1.3