fix: The `remoteEntryChunk` should use the base path from the Vite co…

baijunjie commented 2 months ago

…nfig.

Fixes #629

Description

Under normal circumstances, the reference paths for resource files built by a plugin should align with the base path specified in the Vite config.

Additional context

The filename of the exposed remote module usually doesn't include a hash because it's the entry point for remote modules and needs to be accessible by external applications. Therefore, it is typically deployed separately on Nginx, while other resources are placed on a CDN. If a relative path is used, it can cause a bug where files can't be found.

What is the purpose of this pull request?

[X] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Code of Conduct and follow the Commit Convention guidelines.
[X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[X] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[X] Ideally, include relevant tests that fail without this PR but pass with it.

baijunjie commented 1 month ago

It seems that the CI didn't pass. Is there anything else you need me to do?

ruleeeer commented 1 month ago

It looks like the test fails, does it work locally for you? pnpm test

baijunjie commented 1 month ago

It looks like the test fails, does it work locally for you? pnpm test

These errors don’t seem related to my changes. I also couldn’t pass the tests when running pnpm test on the main branch.

originjs / vite-plugin-federation