search

origo-map / origo

Origo
Other
48 stars 53 forks source link

Remove console.log? #261

Closed markus659 closed 7 years ago

markus659 commented 7 years ago

Should we not remove all the rows with console.log? I think it's more of a debugger/developer tool rather than something that should be included in the production code. Any thoughts?

afogelberg commented 7 years ago

I agree that we in some cases may remove unnecessary console.log. But I would also say that in some cases it's good to get some information on what's going on without having to rely on a debugger tool other than the browser. For example if your'e not a developer and are creating an Origo map this can be helpful information regarding problems with map configuration.

markus659 commented 7 years ago

Fair point. It might still be a big ask of Origo map creators to open the developer tools and look for log messages. Maybe we could utilize the console in the footer for some messages, and perhaps increase the use of alert for some error messages?

afogelberg commented 7 years ago

Maybe we could utilize the console in the footer for some messages, and perhaps increase the use of alert for some error messages?

Good idea. A mix of the two will certainly be useful.

markus659 commented 7 years ago

I will close this for now as I don't think any work needs to be done, but maybe we can try to keep this in mind when coding.