Improvements - Githubissues

hvent90 commented 6 years ago

Video demo: https://drive.google.com/file/d/1Lom11paDOWwDlyIJDkGX9MXsDYRtv_6G/view?usp=sharing Note: A bug is shown in video demo that has been fixed. The modal background is not covering the full page -- the modal background now covers the full page and the user is no longer able to scroll while the modal is activated.

This PR addresses the following issues:

Requests 20 results per search
Smaller result cards are displayed to achieve ~20 results being shown on a desktop computer
Clicking on a result card for a video will pop up a modal with an inline player. Clicking on a result card for a channel will redirect the user to the youtube channel
HQ thumbnails are used with lower quality fallbacks
The height of the main body is animated upon first search instead of instantly being reduced

odeke-em commented 6 years ago

This is amazing, thank you very much @hvent90! LGTM

odeke-em commented 6 years ago

Perfect, please go ahead and merge, if you'd like.

orijtech / media-search