oriolmirosa / open-files

Atom package to show the open files in the tree-view panel, mirroring the functionality in Sublime Text
https://atom.io/packages/open-files
MIT License
15 stars 10 forks source link

Atom update to 1.13 - Object.dirname is deprecated / Object.extname is deprecated #8

Closed misterbridge closed 7 years ago

misterbridge commented 7 years ago

After updating Atom to 1.13 (1.13.1 actually) I got those 2 deprecations warnings.

Argument to path.dirname must be a string

Object.dirname (/usr/share/atom/resources/app.asar/src/electron-shims.js:9:10)
<unknown> (/home/mrbridge/.atom/packages/open-files/lib/open-files-pane-view.js:113:37)
Pane.observeItems (/usr/share/atom/resources/app.asar/src/pane.js:215:9)
OpenFilesPaneView.setPane (/home/mrbridge/.atom/packages/open-files/lib/open-files-pane-view.js:91:26)
OpenFilesView.addTabGroup (/home/mrbridge/.atom/packages/open-files/lib/open-files-view.js:60:10)
<unknown> (/home/mrbridge/.atom/packages/open-files/lib/open-files-view.js:39:10)

Argument to path.extname must be a string

Object.extname (/usr/share/atom/resources/app.asar/src/electron-shims.js:20:10)
<unknown> (/home/mrbridge/.atom/packages/open-files/lib/open-files-pane-view.js:114:37)
Pane.observeItems (/usr/share/atom/resources/app.asar/src/pane.js:215:9)
OpenFilesPaneView.setPane (/home/mrbridge/.atom/packages/open-files/lib/open-files-pane-view.js:91:26)
OpenFilesView.addTabGroup (/home/mrbridge/.atom/packages/open-files/lib/open-files-view.js:60:10)
<unknown> (/home/mrbridge/.atom/packages/open-files/lib/open-files-view.js:39:10)
oriolmirosa commented 7 years ago

Fixed. Thanks for reporting!