search

orion3dgames / gridder

A jQuery plugin that displays a thumbnail grid expanding preview similar to the effect seen on Google Images.
http://orion3dgames.github.io/gridder/
461 stars 130 forks source link

Animate change the same as opening a new panel #34

Closed joneslafuente closed 6 years ago

joneslafuente commented 8 years ago

A good option would be to animate the closing of the open panel before opening the new one. Is this possible to add myself or does it need an update? I am not a programmer. Also could the open panel be closed by clicking on the body of the page? Apart from these points, excellent code.

Thanks

orion3dgames commented 8 years ago

Hello. I've tried in the past with no success, as the movement of sliding up and down makes you feel sea sick... And when you click somewhere you expect an instant reaction, not having to wait .5s for the panel to slide down and then slide up. At the moment, It only slides up when you close the panel with close button.

orion3dgames commented 8 years ago

Adding an clickable overlay beneath the panel is a good idea, i'll look into it for the next version.

joneslafuente commented 8 years ago

Thanks. Look forward to the update.

On Wed, Dec 9, 2015 at 6:55 AM, Orion Gunning notifications@github.com wrote:

Adding an clickable overlay beneath the panel is a good idea, i'll look into it for the next version.

— Reply to this email directly or view it on GitHub https://github.com/oriongunning/gridder/issues/34#issuecomment-163134927 .

joneslafuente commented 8 years ago

I agree with the effect of sliding one closed and then another opening may not be so great. Thanks.

On Wed, Dec 9, 2015 at 6:55 AM, Orion Gunning notifications@github.com wrote:

Hello. I've tried in the past with no success, as the movement of sliding up and down makes you feel sea sick... And when you click somewhere you expect an instant reaction, not having to wait .5s for the panel to slide down and slide up. It only slides up when you close the panel with close button.

— Reply to this email directly or view it on GitHub https://github.com/oriongunning/gridder/issues/34#issuecomment-163134898 .

orion3dgames commented 6 years ago

After reflexion, the overlay (modal style) does not seem like a good feature as it would cause unwanted closing, etc..