orionjs / orioncms

[Old] Orion is an open source framework built on Meteor that makes complex as well as simple apps possible with minimal effort.
http://orionjs.org
MIT License
715 stars 129 forks source link

This packages `imply` way too much #381

Closed mitar closed 8 years ago

mitar commented 8 years ago

I would like to complain a bit. The approach in this repository where so many packages are implyed, makes it really hard to reuse this system with other Meteor packages:

It destroys the whole purpose of dependencies by creating one monolithic package you can or cannot use.

For example, it is now impossible to use orionjs:core together with Blaze Components because orionjs:core implies orionjs:base which implies blaze-html-templates. Why it has to imply it and not just depend on it? This makes it problematic for users who would like to swap templating with Blaze Components and get also server side rendering.

mitar commented 8 years ago

Or probably better solution would be that orion:core would not imply orion:base, just depend on it.

mitar commented 8 years ago

This is now a better fix.

macrozone commented 8 years ago

Has this version been published to atmosphere? I ran in the exaclty described problem with BlazeComponents.

Edit: sorry, did not realized, that this PR is not merged yet.

nicolaslopezj commented 8 years ago

This will be fixed in 1.8

macrozone commented 8 years ago

:+1: awesome