orithena
commented
7 years ago Hey @kktuax,
Thanks for the feedback!
I added mpd support solely for auto-pausing music playback during a video; mpd is the music player daemon i use on my raspberry. Streaming the audio of omxplayer over the network would be harder, I think... without researching it further, I only see pulseaudio magic as an option.
Maybe I should make the whole mpd library dependency configurable, that would remove the need for it's own branch... but on the other hand, using feature branches in both repos is definitely a good idea for future development.
Also, I think of an event hook system to simplify configurable mpd support and also to ease the way for plugin support...
Hi @orithena
Recently I have merged in the original repo most of your changes, nice work! I just have removed the mpd logic, and reorganized a bit the buttons of the UI. Please check it out. I liked the idea of the paste URL. I have integrated the pasted URL with youtube-dl so now you can also paste other types of urls and it fetches the available videos.
Regarding the decision about supporting mpd, correct me if I'm wrong: you are streaming the omxplayer audio over the network? I'm considering if I should integrate it in the original codebase.
In any case, for further improving the compatibility of our repositories, maybe we could define a branch for this feature. This way integrating changes would be much easier.