Closed smoelius closed 1 year ago
Merging #165 (956d80a) into master (328d410) will increase coverage by
0.26%
. The diff coverage is100.00%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
+ Coverage 90.17% 90.44% +0.26%
==========================================
Files 13 13
Lines 957 984 +27
==========================================
+ Hits 863 890 +27
Misses 94 94
Impacted Files | Coverage Δ | |
---|---|---|
src/utils.rs | 100.00% <ø> (ø) |
|
src/transform/intralinks/mod.rs | 92.94% <100.00%> (+0.66%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Looks good. Thanks.
Thank you!
Resolves #163
I did things a little differently than you suggested. I made
MarkdownInlineLink
look like this:This seemed sensible to me since:
MarkdownInlineLink
methods did not usetext
and thus could becomeMarkdownLink
methods.markdown_link
function could be modified to take aMarkdownLink
as its first argument and thus be used in a new function,rewrite_reference_definitions
, analogous torewrite_markdown_links
.A point of note:
rewrite_reference_definitions
iterates usingParser::reference_definitions
. However, the iterator that method returns retains a reference to the parser. As such, the code that would have gone into amarkdown_reference_definitions_iterator
function (analogous tomarkdown_inline_link_iterator
) is instead inlined intorewrite_reference_definitions
. Getting lifetimes to work for amarkdown_reference_definitions_iterator
function would seem to require non-trivial changes.Hopefully, everything else is straightforward. Nits are welcome.