orium / rpds

Rust persistent data structures
Mozilla Public License 2.0
1.28k stars 58 forks source link

thanks #12

Closed dotnwat closed 6 years ago

dotnwat commented 6 years ago

I have been hacking on a persistent red-black tree in C++ recently. I just wanted to say thank you for your Rust implementation. It's been incredibly useful in getting this working!

orium commented 6 years ago

I'm happy to hear that! If you find a nicer way to rebalance on remove() let me know :)

dotnwat commented 6 years ago

@orium ditto. all i've heard is that delete is messy, and there's no way around it. we are currently using a different persistent red-black tree algorithm, and it is also complicated, but it does seem to be a bit less complex / less code: https://github.com/cruzdb/cruzdb/blob/master/src/db/persistent_tree.h#L180 i haven't done any performance comparisons.