orium / rpds

Rust persistent data structures
Mozilla Public License 2.0
1.24k stars 58 forks source link

Add get_mut() to maps #52

Closed arthurprs closed 3 years ago

arthurprs commented 3 years ago

With it the user can avoid the clunky pattern get() + clone + modify + insert(). Especially useful if you have early returns (eg. with ?) in between.

codecov-io commented 3 years ago

Codecov Report

Merging #52 (e8bed47) into master (60a2f9c) will decrease coverage by 0.40%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   93.24%   92.83%   -0.41%     
==========================================
  Files          11       11              
  Lines        1583     1620      +37     
==========================================
+ Hits         1476     1504      +28     
- Misses        107      116       +9     
Impacted Files Coverage Δ
src/map/entry.rs 100.00% <ø> (ø)
src/map/red_black_tree_map/mod.rs 92.81% <55.55%> (-0.67%) :arrow_down:
src/map/hash_trie_map/mod.rs 91.78% <78.57%> (-0.94%) :arrow_down:
src/list/mod.rs 91.66% <100.00%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60a2f9c...e8bed47. Read the comment docs.

orium commented 3 years ago

Merged. Thanks.

arthurprs commented 3 years ago

I was hoping you could make a new release? That will include the rand 0.8 update and the get_mut. Thank you :pray:

orium commented 3 years ago

Sure. Released v0.9.0.