jwedel
commented
4 years ago Note that GitHub doesn't support creating new branches in the target repo. That's why we got the merge error here. First, a new branch from https://github.com/orizens/ngx-infinite-scroll/commit/fa01a048a7f98bcf42ac883051318f04f9e5baf0 needs to be created. Then, this can be merged. It should not be merged into master/HEAD.
orizens
This changes has been cherry-picked from the PR made for #321 and fixes #329. An ng-6 branch has been created from the 6.0.1 release.
There are a few known scenarios where the opencollective postinstall npm script can cause things to break further down the pipeline - a few being 'certain build/CI environments', 'script permission issues' and 'offline installs'....
Arguably, displaying a banner soliciting funding shouldn't disrupt the development or build processes of projects leveraging libraries that are optionally, and non-functionally, using opencollective.
Ultimately, at the heart of the failure, is a non 0 exit code being returned in the cases that opencollective fails to properly execute.
To prevent this non-zero exit code failure so that subsequent npm processes aren't disrupted as a result of non-functional dependency issues, a "|| exit 0" should be added to the postinstall npm script.
There are many discussions about this issue and workaround - here are a few: opencollective/opencollective-cli#5 nuxt/nuxt.js#1357 opencollective/opencollective-cli#3 opencollective/opencollective-postinstall#2 https://github.com/compodoc/compodoc/commit/99ea09f6ac75fe26001c2fae52facc3be1696a52
(cherry picked from commit c5613d7386cbbe074e5bb62a77bba85e906060fb)