search

orizens / ngx-infinite-scroll

Infinite Scroll Directive for Angular
https://www.npmjs.com/package/ngx-infinite-scroll
MIT License
1.23k stars 223 forks source link

feat: update to angular 9 #351

Closed santoshyadavdev closed 4 years ago

santoshyadavdev commented 4 years ago

A similar PR may already be submitted! Please search among the Pull request before creating one.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request.

Summary

This PR fixes/implements the following bugs/features

orizens commented 4 years ago

@santoshyadav198613 thanks for raising this pr. is that ready for review?

santoshyadavdev commented 4 years ago

Hi @orizens , This is ready for review now.

orizens commented 4 years ago

@santoshyadav198613 have you verified unit tests are passing?

santoshyadavdev commented 4 years ago

image yes working can you add github action so it can be verified on each pull request

orizens commented 4 years ago

travis build was failing. i fixed it. should be good now.

orizens commented 4 years ago

@santoshyadav198613 can you advice: should there be any breaking changes?

santoshyadavdev commented 4 years ago

@santoshyadav198613 can you advice: should there be any breaking changes?

No breaking changes the update should be smooth.

santoshyadavdev commented 4 years ago

Hi @orizens , Can we merge this?

orizens commented 4 years ago

thanks @santoshyadav198613 v9.0.0 is live now.