orizens / ngx-infinite-scroll

Infinite Scroll Directive for Angular
https://www.npmjs.com/package/ngx-infinite-scroll
MIT License
1.23k stars 223 forks source link

Production build produces unwanted console logs. #356

Closed AlexA-1976 closed 2 months ago

AlexA-1976 commented 4 years ago

Expected Behavior

No console logging should happen unless I explicitly put it there.

Actual Behavior

Every scroll-down this appears in the console log. On debug build, it doesn't happen.

(2)  [{…}, {…}] 0: {contentHeight: undefined, scrolledFromTop: undefined, viewportHeight: undefined} 1: {contentHeight: undefined, scrolledFromTop: undefined, viewportHeight: undefined} length: 2 proto: Array(0)

Steps To Reproduce / Demo (if applicable)

Using 'infiniteScroll' on a ul element. Scrolling behavior works.

Your Environment

"ngx-infinite-scroll": "^6.0.0",
"@angular/core": "6.1.10",
orizens commented 4 years ago

hi @AlexA-1976 if you open a pr for v6 - i can publish it as next 6.

AlexA-1976 commented 4 years ago

@orizens I looked in the source just now and couldn't find any console.log() calls. Is it possible some lower level library is doing this?

orizens commented 4 years ago

might be. you would have to look into a commit from v6.

orizens commented 4 years ago

checkout this commit https://github.com/orizens/ngx-infinite-scroll/tree/fa01a048a7f98bcf42ac883051318f04f9e5baf0

VikasKad commented 3 years ago

Is there any update on this issue? I am still getting this error. My environment details are as follows: "@angular/core": "^6.0.0", "ngx-infinite-scroll": "^6.0.0",

orizens commented 3 years ago

@VikasKad i dont see any pr for version 6.

VikasKad commented 3 years ago

checkout this commit https://github.com/orizens/ngx-infinite-scroll/tree/fa01a048a7f98bcf42ac883051318f04f9e5baf0

I Checked in this commit, but I didn't find any console.log in it as well.