search

orizens / ngx-infinite-scroll

Infinite Scroll Directive for Angular
https://www.npmjs.com/package/ngx-infinite-scroll
MIT License
1.25k stars 223 forks source link

Angular 10 compatibility #365

Closed bisonfoutu closed 3 years ago

bisonfoutu commented 4 years ago

Actual Behavior

The Readme indicates that this lib now follows Angular versions to reflect compatibility. There is currently no available 10.X.X version for ngx-infinite-scroll, suggesting that the library is not compatible with Angular 10.

Possible Solution

If the library is already compatible, consider bumping the version to 10.0.0. If not, I would be happy to help make it so !

Context

I am considering upgrading my apps to Angular 10, and before doing so I would like to be sure that all my dependencies are compatible.

slcoder commented 4 years ago

Hello, this library is not compatible with angular 10, I tried to integrate this with my latest application (Angular 10), doesn't work. Please, anyone, take a look at this?

bisonfoutu commented 4 years ago

@slcoder I just made this simple working example using Angular 10 and ngx-infinite-scroll@9.1.0: Obviously this does not cover all use cases, so feel free to link a repo to illustrate your own use case.

@orizens do you plan to address this any time soon ? I'd gladly raise a PR but will probably need your assistance.

slcoder commented 4 years ago

@slcoder I just made this simple working example using Angular 10 and ngx-infinite-scroll@9.1.0: Obviously this does not cover all use cases, so feel free to link a repo to illustrate your own use case.

@orizens do you plan to address this any time soon ? I'd gladly raise a PR but will probably need your assistance. @bisonfoutu Thank you very much, let me try this

orizens commented 4 years ago

@slcoder I just made this simple working example using Angular 10 and ngx-infinite-scroll@9.1.0: Obviously this does not cover all use cases, so feel free to link a repo to illustrate your own use case.

@orizens do you plan to address this any time soon ? I'd gladly raise a PR but will probably need your assistance.

Sure. Please do

abdatta commented 4 years ago

Is anybody working on this? If not I'll raise a PR soon.

bisonfoutu commented 4 years ago

@abdatta please do, I will probably not have time to do this in the next few days.

orizens commented 3 years ago

v10 released.