search

orizens / ngx-infinite-scroll

Infinite Scroll Directive for Angular
https://www.npmjs.com/package/ngx-infinite-scroll
MIT License
1.25k stars 224 forks source link

Shipping without @scarf/scarf #417

Closed gbmeow closed 1 year ago

gbmeow commented 1 year ago

I would like to understand if you are still shipping @scarf/scarf with your code. Would you need to turn it off, using https://github.com/orizens/ngx-infinite-scroll/issues/352#issuecomment-742009046 or if we should ignore the need to turn it off? Reason: While @scarf/scarf is inside the package.json, it seems that npm packages, do not ship @scarf/scarf as a dependency

Currently https://github.com/orizens/ngx-infinite-scroll/blob/master/package.json#L24 (@scarf/scarf) https://www.npmjs.com/package/ngx-infinite-scroll/v/15.0.0?activeTab=code (no @scarf/scarf)

Reproduce add "ngx-infinite-scroll": "^6.9.1", to package.json SCARF_VERBOSE=true run npm i

Result

ngx-infinite-scroll@6.9.1 postinstall /Users/georgeb/node_modules/ngx-infinite-scroll opencollective-postinstall || exit 0

sh: opencollective-postinstall: command not found

Nothing from @scarf/scarf

Is @scarf/scarf still being shipped to users of ngx-infinite-scroll?

gbmeow commented 1 year ago

Is this a matter of the gateway doing that for your package https://docs.scarf.sh/gateway/#figure_1?