search

orizens / ngx-infinite-scroll

Infinite Scroll Directive for Angular
https://www.npmjs.com/package/ngx-infinite-scroll
MIT License
1.23k stars 224 forks source link

Upgrade to Angular 17 ? #429

Closed medbenmakhlouf closed 8 months ago

medbenmakhlouf commented 8 months ago

Is there any release plan for Angular 17? Thanks

saheemshafi commented 8 months ago

I want to know too. I was trying to upgrade my app from v16 to v17 and coudn't progess because of ngx-infinite-scroll version. Any updates?

alecwest commented 8 months ago

@medbenmakhlouf @saheemshafi based on previous upgrade issues (https://github.com/orizens/ngx-infinite-scroll/pull/419, https://github.com/orizens/ngx-infinite-scroll/issues/412, etc), it sounds as if anyone is welcome to contribute.

If no one else beats me to it I'd like to give it a try.

saheemshafi commented 8 months ago

@medbenmakhlouf @saheemshafi based on previous upgrade issues (#419, #412, etc), it sounds as if anyone is welcome to contribute.

If no one else beats me to it I'd like to give it a try.

If you want to start you can. I can't start soon and I won't start if you would.

medbenmakhlouf commented 8 months ago

I have opened a PR here : https://github.com/orizens/ngx-infinite-scroll/pull/430

@orizens , would you mind to take a look please ?

Thanks

alecwest commented 8 months ago

I have opened a PR here : #430

@orizens , would you mind to take a look please ?

Thanks

thanks for starting that. It was probably going to be another day before I could properly get to it as well. 😄

saheemshafi commented 8 months ago

I have opened a PR here : #430

@orizens , would you mind to take a look please ?

Thanks

I will have a look. Thanks for starting that. Will let you know about it shortly.

orizens commented 8 months ago

thanks @medbenmakhlouf reviewing

medbenmakhlouf commented 8 months ago

closing the issue as it was merged : https://github.com/orizens/ngx-infinite-scroll/pull/430