respect react/jsx-closing-bracket-location

orktes / atom-react

ReactJS Support for atom (syntax, snippets)

http://orktes.github.io/atom-react/

MIT License

476 stars 78 forks source link

respect react/jsx-closing-bracket-location #129

Open dmnd opened 8 years ago

dmnd commented 8 years ago

Airbnb's react style guide is quite popular. But the indentation rules of this package are incompatible with it. Here's the style guide rule. Below is what this package defaults to.

Is there a way to get Atom to respect my eslint settings? Failing that, it would be nice to make the closing > location configurable at the package level.

jeffshaver commented 8 years ago

:+1:

orktes commented 8 years ago

Hi!

@jeffshaver just did a PR concerning this (though it is'nt reading eslint conf). Kudos on that. Reading/respecting eslint rules is a separate feature that is worth pursuing. I'll add a ticker for that.

https://github.com/orktes/atom-react/pull/131

axelson commented 8 years ago

Note that the PR (https://github.com/orktes/atom-react/pull/131) was merged and then reverted (https://github.com/orktes/atom-react/commit/22aea6e6d54aa646d321b732ecec8a76014f4233). Looking forward to this feature!

hnordt commented 8 years ago

I'm looking forward to have this feature too!

Silviu-Marian commented 8 years ago

I have had this problem for the last 6 months. A fix would really be appreciated.

nukeop commented 6 years ago

Still working this way.