search

orlandos-nl / BSON

Native Swift library for BSON (http://bsonspec.org)
https://orlandos.nl/docs/mongokitten/articles/bson
MIT License
109 stars 35 forks source link

Added support for setting BSONDecoder.userInfo #46

Closed neallester closed 2 years ago

neallester commented 6 years ago

This is a slightly modified version of the previously submitted and withdrawn pull request: https://github.com/OpenKitten/BSON/pull/44

This change enables application developers to set BSONDecoder.userInfo. A test was added in BSONCodableTests and it passes on High Sierra but it appears that none of the BSONCodableTests run on Linux so it has not been run there.

It also includes some changes to the original pull request:

  1. It includes a test demonstrating that either a concern raised for the original pull request ("userInfo is passed to sub-decoders but not back up") is either not an issue or that I don't correctly understand the issue.
  2. Minor access control changes required to allow clients from outside the module to use the userInfo features.
Obbut commented 6 years ago

I didn't test it yet, but it looks good to me 🙂