search

orlandos-nl / BSON

Native Swift library for BSON (http://bsonspec.org)
https://orlandos.nl/docs/mongokitten/articles/bson
MIT License
110 stars 35 forks source link

Issue 50 #56

Closed markltownsend closed 5 years ago

markltownsend commented 5 years ago

Make code changes so that BSON 5.2.x will compile under Swift 4.x and Xcode 10.2+. Hopefully this can be made into a 5.2.5 so that users of 5.2.x don't have to migrate to 6.x if they don't have to.

Joannis commented 5 years ago

Interesting PR, but big thanks for contributing! I'm not sure how backwards-compatible your change in Document+ParsingSupport.swift is, but I'll have to test it later this evening.

Did you see if it compiles under the now obsolete Swift 3? I'd prefer to not break compatibility for existing projects/users.

Joannis commented 5 years ago

I'm unable to get Swift 3.1.1 up and running anymore. I'll pass this by @Obbut and then we'll decide on what to do. Thanks for the PR anyways!

Joannis commented 5 years ago

We've decided to merge this, since 3.x is unsupported and we're unable to test it.