TTY executing function may stuck forever when inShell is true

[owenzhao]

TTY added ";exit\n" in its code. However, if a command has already ended with ";", a parse error of ";;" is risen and the in shell can't quit.

Since the in shell is not quit, the app calls this api won't get the buffer and the app waits forever.

related function:

public func executeCommand(_ command: String, maxResponseSize: Int = .max, mergeStreams: Bool = false, inShell: Bool = false) async throws -> ByteBuffer

Try: "ls abc;" as command.

[Joannis]

I'm not sure what a correct solution would be. After some thought the only idea I have is to set a timeout for executing commands in the shell

[owenzhao]

How about "\\\n;exit\n"? I worked in zsh with "ls abc" with or without ";" at the end.

[Joannis]

That's a good solution :)