search

orlangure / gocovsh

Go Coverage in your terminal: a tool for exploring Go Coverage reports from the command line 💻
GNU General Public License v3.0
354 stars 14 forks source link

Support configurable colors (themes) #4

Open orlangure opened 2 years ago

bashbunni commented 2 years ago

Hey! I'm working on this right now and I'm curious as to how we want the users to set their theme? Would we have a flag for it that you need to run each time or write to some gocovsh config file in .config/gocovsh

bashbunni commented 2 years ago

an environment variable would probably be the easiest

bashbunni commented 2 years ago

I created a PR that works with an environment variable. The thing is, it's not fully working. I'm getting a nil pointer error - shown in the demo GIF attached to the PR

thelooter commented 10 months ago

Are further contributions adding themes welcome? Or should a more modular approach, which doesn't require adding Code for every new theme, be used?

orlangure commented 6 months ago

Hey @thelooter and sorry for taking so long to respond here.

Theme and other contributions are welcome. I have a task somewhere to support configurable theme files so that no code changes are required to customize the looks, but it would require refactoring of existing code.

I'll be happy to accept both "hard coded" themes and externally configurable themes if you still wish to work on this. Thanks!