search

orliesaurus / nodemailer-mailgun-transport

nodemailer is an amazing node module to send emails within any of your nodejs apps. This is the transport plugin that goes with nodemailer to send email using Mailgun 🔫
MIT License
882 stars 98 forks source link

Support all the options Mailgun supports #32

Closed holm closed 8 years ago

holm commented 8 years ago

This PR adds support for passing all the options to Mailgun that it supports.

The full list of data supported can be found here: https://documentation.mailgun.com/api-sending.html#sending

This uses a few lodash functions, that could probably be inlined, but since the dependencies are tiny, I felt this is the cleaner way to do it.

holm commented 8 years ago

Since I kept making a few mistakes, I added some simple tests also.

holm commented 8 years ago

I also added a travis file to test on older node versions down to 0.10. I had to add lodash.startswith to get it to work on the oldest versions, but it passes on all now.

orliesaurus commented 8 years ago

thanks @holm - super appreciated

holm commented 8 years ago

Thanks. I would encourage you to enable Travis CI for this repo, so new commits and PR's are automatically tested. It's free for open source projects: https://travis-ci.org/

orliesaurus commented 8 years ago

Yeah I know its a thing in the open source world, hopefully this weekend if the weather is ugly enough :)

holm commented 8 years ago

Any chance you could release a version? Would like to get back to the main release, and off my branch :) Thanks.

orliesaurus commented 8 years ago

oh I thought I did, I must have forgotten! Let me do it asap

orliesaurus commented 8 years ago

done - thanks