search

orliesaurus / nodemailer-mailgun-transport

nodemailer is an amazing node module to send emails within any of your nodejs apps. This is the transport plugin that goes with nodemailer to send email using Mailgun 🔫
MIT License
882 stars 98 forks source link

Fixed attachments #38

Closed havokentity closed 8 years ago

havokentity commented 8 years ago

Fixed attachments to work and conforming to nodemailer "attachments" instead of "attachment"

@orliesaurus Hope this helps!

jonathanprl commented 8 years ago

I've already opened an almost identical pull request. :laugh:

https://github.com/orliesaurus/nodemailer-mailgun-transport/pull/35

orliesaurus commented 8 years ago

make my life easy and tell me which one to merge i'm on an airplane right now 🎯

jonathanprl commented 8 years ago

I've updated the tests on mine, so I guess mine?

On Fri, 1 Jul 2016 05:16 orliesaurus, notifications@github.com wrote:

make my life easy and tell me which one to merge i'm on an airplane right now 🎯

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/orliesaurus/nodemailer-mailgun-transport/pull/38#issuecomment-229850287, or mute the thread https://github.com/notifications/unsubscribe/ABbMfCbaCwTG668i0btbVW6whskmB93Mks5qRJStgaJpZM4JBz0J .

havokentity commented 8 years ago

Haha, just saw, yeah guess Jonathans'

On Fri, Jul 1, 2016 at 12:50 PM, Jonathan Lambert notifications@github.com wrote:

I've updated the tests on mine, so I guess mine?

On Fri, 1 Jul 2016 05:16 orliesaurus, notifications@github.com wrote:

make my life easy and tell me which one to merge i'm on an airplane right now 🎯

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/orliesaurus/nodemailer-mailgun-transport/pull/38#issuecomment-229850287 , or mute the thread < https://github.com/notifications/unsubscribe/ABbMfCbaCwTG668i0btbVW6whskmB93Mks5qRJStgaJpZM4JBz0J

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/orliesaurus/nodemailer-mailgun-transport/pull/38#issuecomment-229874326, or mute the thread https://github.com/notifications/unsubscribe/AB3YxTjFiy-NmXwgVyEcIM5phfYp-eMXks5qRL-4gaJpZM4JBz0J .

Rajesh Peter Douglas D'Monte

http://www.rajeshdmonte.com/

orliesaurus commented 8 years ago

Okay boys! :)

jonathanprl commented 8 years ago

@orliesaurus Thanks. I updated the tests in mine by the way #35, if you haven't done so yourself already.