search

orliesaurus / nodemailer-mailgun-transport

nodemailer is an amazing node module to send emails within any of your nodejs apps. This is the transport plugin that goes with nodemailer to send email using Mailgun 🔫
MIT License
882 stars 98 forks source link

Added links in attachments support #65

Closed fedirkh closed 2 years ago

fedirkh commented 7 years ago

If you have any suggestions about code style, please tell me.

orliesaurus commented 7 years ago

Cool, would love to see some tests maybe 👍

orliesaurus commented 7 years ago

additionally, why are you using "co" ? wouldn't it be better to use async await (just for an example of the clean feeling watch this: https://medium.com/@Abazhenov/using-async-await-in-express-with-node-8-b8af872c0016 )

fedirkh commented 7 years ago

async-await operators are cool, but they're supported only from node v7, and it will break compatibility for earlier node versions. I think a lot of people needs this in node < 7, at least I need :) I propose to leave co in 1.4.0 (because co doesn't supported by node < 4) package version, and replace it by async-await in, maybe, 1.5.0 or 2.0.0, to not break compatibility. What do you think about this?

orliesaurus commented 6 years ago

I think that's OK I just have to do it out of catch up on this module and I will merge this as soon as I get a chance and to publish it afterwards

henrinormak commented 2 years ago

Any update on this? This would close #16 IIRC

fedirkh commented 2 years ago

Repo code was changed dramatically since PR opening, so this task should be done from scratch now I guess