Closed captaincaius closed 3 years ago
gonna review it asap
Aren't mailgun templates working already?
I don't think the template is being unset anywhere and with this check the template is being run through consolidate only if it's a consolidate engine: https://github.com/orliesaurus/nodemailer-mailgun-transport/pull/82/files#diff-7987c848bbcea3b28cbb236f62eee701L67
EDIT: I see, template is not whiltelisted and if whitelisted we can't send the full consolidate object (needs to be a string)
PR obsoleted by the rewrite - tests and docs added instead in #99
There's also a first commit that fixes a little problem in the tests.