Feature: support mailgun templates (closes #80)

orliesaurus / nodemailer-mailgun-transport

nodemailer is an amazing node module to send emails within any of your nodejs apps. This is the transport plugin that goes with nodemailer to send email using Mailgun 🔫

MIT License

880 stars 97 forks source link

Feature: support mailgun templates (closes #80) #82

Closed captaincaius closed 3 years ago

captaincaius commented 5 years ago

There's also a first commit that fixes a little problem in the tests.

orliesaurus commented 5 years ago

gonna review it asap

framp commented 5 years ago

Aren't mailgun templates working already?

I don't think the template is being unset anywhere and with this check the template is being run through consolidate only if it's a consolidate engine: https://github.com/orliesaurus/nodemailer-mailgun-transport/pull/82/files#diff-7987c848bbcea3b28cbb236f62eee701L67

EDIT: I see, template is not whiltelisted and if whitelisted we can't send the full consolidate object (needs to be a string)

captaincaius commented 3 years ago

PR obsoleted by the rewrite - tests and docs added instead in #99