search

orlikoski / CDQR

The Cold Disk Quick Response (CDQR) tool is a fast and easy to use forensic artifact parsing tool that works on disk images, mounted drives and extracted artifacts from Windows, Linux, MacOS, and Android devices
GNU General Public License v3.0
332 stars 51 forks source link

Pep8 Formatting #41

Closed nix2intel closed 5 years ago

nix2intel commented 5 years ago

Went from ~600 pep8 violations to 181 (most of which are too long of lines)

orlikoski commented 5 years ago

Have you done any testing on the code to make sure the functions all work?

orlikoski commented 5 years ago

I think this is great work. It'll just require testing to make sure all the functions still work as intended as there were a lot of changes

nix2intel commented 5 years ago

I'm doing some manual testing now i'll keep you updated. None of this should be breaking changes but i'll let you know asap.

nix2intel commented 5 years ago

Everything I normally do works as expected. I had no issues with it on my Mac.

orlikoski commented 5 years ago

I understand that's how it normally works. I want to spend some time testing, or hearing about how you tested, to ensure all the functions work.

For example, the code in https://github.com/orlikoski/CDQR/commit/2a537dae6d18035f06f1fa319edc383f00b6c186 required me to do https://github.com/orlikoski/CDQR/commit/021c66a26cb312b59d91f6c50f66400d6b398180 in order to get it working fully.

I want to be extra cautious to catch things prior to pushing to master now.

Would you be interested in helping me put together some build tests? It would make this process much easier / faster for everyone.

nix2intel commented 5 years ago

Yes totally cool. I would love to help put together some build tests. I’ll start digging into this. Have had some serious life changing events but want to help out with this.

orlikoski commented 5 years ago

Moving this merge into a dev branch that will enable us to test without merging to master